-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support cmdclass in setup.cfg #2570
Comments
makeroo
pushed a commit
to makeroo/setuptools
that referenced
this issue
Feb 18, 2021
2 tasks
jaraco
added a commit
that referenced
this issue
Feb 26, 2021
Correctly parse cmdclass in setup.cfg. Fixes #2570
This was referenced Mar 8, 2021
This was referenced Mar 15, 2021
This was referenced Mar 15, 2021
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Having cmdclass defined in setup.cfg causes sdist, or any other, command to fail because its value is not properly parsed into a dict.
How to replicate
setup.cfg example:
setup.py:
build.py
error:
It happens because self.cmdclass evaluates to the string "sdist = build.CustomSdistCommand" but it should be { "sdist": <class 'build.CustomSdistCommand'> }
Environment details:
PIP: 21.0.1
setuptools: 53.0.0
Possible solutions:
either change setup.cfg structure introducing options.cmdclass section or fix setuptools/dist.py Distribution._parse_config_files method so that it parses cmdclass value.
Full minimal example:
example.zip
The text was updated successfully, but these errors were encountered: