Handle AttributeError by raising DistutilsSetupError in check_specifier. Fixes #1932 #2583
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Closes #1932
Dist.check_specifier
verifies that the specifiers are valid and raisesDistutilsSetupError
if found invalid, however in the situation that the specifier is a non-string (e.g. a list with a string element) it would fail with anAttributeError
becauseSpecifierSet
from _vendor/packaging will assume that the specifier is a string. This fix will changecheck_specifier
to handle theAttributeError
by raisingDistutilsSetupError
when the situation of a non-string specifier occurs.Pull Request Checklist
changelog.d/
.(See documentation for details)