Handling encodings correctly

Fixes #457

tests/test_cmdline.py

@@ -1,3 +1,4 @@
+# coding: utf-8
 import sys
 import subprocess
 import virtualenv
@@ -22,6 +23,14 @@ def test_commandline_explicit_interp(tmpdir):
         str(tmpdir.join('venv'))
     ])
 
+def test_commandline_non_ascii_path(tmpdir):
+    subprocess.check_call([
+        sys.executable,
+        VIRTUALENV_SCRIPT,
+        '-p', sys.executable,
+        str(tmpdir.join('venv中文'))
+    ])
+
 # The registry lookups to support the abbreviated "-p 3.5" form of specifying
 # a Python interpreter on Windows don't seem to work with Python 3.5. The
 # registry layout is not well documented, and it's not clear that the feature

virtualenv.py

@@ -729,6 +729,7 @@ def call_subprocess(cmd, show_stdout=True,
                 part = part.decode(sys.getfilesystemencoding())
         cmd_parts.append(part)
     cmd_desc = ' '.join(cmd_parts)
+    cmd_desc = cmd_desc.encode('utf-8')
     if show_stdout:
         stdout = None
     else:
@@ -1376,8 +1377,9 @@ def install_python(home_dir, lib_dir, inc_dir, bin_dir, site_packages, clear, sy
         # the value:
         py_executable = '"%s"' % py_executable
     # NOTE: keep this check as one line, cmd.exe doesn't cope with line breaks
-    cmd = [py_executable, '-c', 'import sys;out=sys.stdout;'
-        'getattr(out, "buffer", out).write(sys.prefix.encode("utf-8"))']
+    cmd = [py_executable, '-c', 'import sys;out=sys.stdout;prefix=sys.prefix;'
+        'prefix=prefix.encode("utf-8") if sys.version_info[0]==3 else prefix;'
+        'getattr(out, "buffer", out).write(prefix)']
     logger.info('Testing executable with %s %s "%s"' % tuple(cmd))
     try:
         proc = subprocess.Popen(cmd,