Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use unix line-endings in bash activate script #1924

Merged
merged 7 commits into from
Aug 23, 2020

Conversation

saytosid
Copy link
Contributor

@saytosid saytosid commented Aug 15, 2020

Fixes: #1818

Signed-off-by: Siddhant Kumar skumar619@bloomberg.net

Thanks for contributing, make sure you address all the checklists (for details on how see

development documentation)!

  • ran the linter to address style issues (tox -e fix_lint)
  • wrote descriptive pull request text
  • ensured there are test(s) validating the fix
  • added news fragment in docs/changelog folder
    - [ ] updated/extended the documentation - N/A, this is a bug fix

@codecov
Copy link

codecov bot commented Aug 15, 2020

Codecov Report

Merging #1924 into master will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1924      +/-   ##
==========================================
- Coverage   93.98%   93.96%   -0.02%     
==========================================
  Files          86       86              
  Lines        4221     4225       +4     
==========================================
+ Hits         3967     3970       +3     
- Misses        254      255       +1     
Flag Coverage Δ
#tests 93.96% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/virtualenv/activation/via_template.py 100.00% <100.00%> (ø)
src/virtualenv/create/via_global_ref/api.py 95.89% <100.00%> (+0.05%) ⬆️
src/virtualenv/util/path/_pathlib/via_os_path.py 91.50% <100.00%> (+0.16%) ⬆️
src/virtualenv/seed/embed/base_embed.py 96.22% <0.00%> (-1.89%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7de4f3f...a407870. Read the comment docs.

@saytosid saytosid force-pushed the fix/1818 branch 4 times, most recently from 4246291 to 446d93e Compare August 16, 2020 11:53
Signed-off-by: Siddhant Kumar <skumar619@bloomberg.net>
Signed-off-by: Bernat Gabor <bgabor8@bloomberg.net>
Signed-off-by: Bernat Gabor <bgabor8@bloomberg.net>
Signed-off-by: Bernat Gabor <bgabor8@bloomberg.net>
@gaborbernat gaborbernat force-pushed the fix/1818 branch 4 times, most recently from 47dadfb to ebe560c Compare August 21, 2020 09:49
Signed-off-by: Bernat Gabor <bgabor8@bloomberg.net>
Signed-off-by: Bernat Gabor <bgabor8@bloomberg.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issues creating and activating a virtualenv in git bash
2 participants