Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for validating activation output and setuptools test integration. #635

Merged
merged 1 commit into from
Aug 8, 2014

Conversation

shidesthewise
Copy link

Fix expected output to match actual output for setuptools
and pip installation progress. The progress line has been
one line for a while but the expected output was looking for
two lines.

Rename tests to test to fix python setup.py test functionality.

@pfmoore
Copy link
Member

pfmoore commented Aug 6, 2014

This patch still does 2 things, I'm afraid. I'm happy with the change to the output check, but less sure about the tests->test change (tests is pretty standard when using py.test AIUI, and is what pip uses as well). Why not fix setup.py to correctly use tests instead of renaming?

(I'm not going to block this on the renaming, though - if another core committer is happy with it going in, that's fine with me).

@shidesthewise
Copy link
Author

I can split it out easily enough. Sorry about misunderstanding splitting out the testing fixes into two separate pulls. The current setup.py is hijacking setuptools's builtin test command to execute py.test but whatever arguments are passed to setup.py pass through to py.test which is assuming they are a file or directory.

I can change python setup.py test to use the built-in (no-op for this project) and instead use python setup.py tests

@shidesthewise
Copy link
Author

In this case the test is both the setup.py command and the directory in which to find tests.

and pip installation progress.  The progress line has been
one line for a while but the expected output was looking for
two lines.
@shidesthewise
Copy link
Author

The fix for setup.py is in its own PR now: #638

pfmoore added a commit that referenced this pull request Aug 8, 2014
Fixes for validating activation output and setuptools test integration.
@pfmoore pfmoore merged commit a02905e into pypa:develop Aug 8, 2014
@pfmoore
Copy link
Member

pfmoore commented Aug 8, 2014

Merged this. Thanks for your persistence with this. Improving the tests is really useful, and sadly doesn't get much developer focus, so your help is much appreciated.

@shidesthewise shidesthewise deleted the feature/testfix-1 branch December 5, 2014 19:40
@dstufft dstufft mentioned this pull request Jan 5, 2015
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants