enable verbose output #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
modified: southwest/southwest.py
modified: southwest/southwest.py
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
| @@ -46,8 +46,8 @@ def schedule_checkin(flight_time, reservation): | |||
| print("{} got {}{}!".format(doc['name'], doc['boardingGroup'], doc['boardingPosition'])) | |||
|
|
|||
|
|
|||
| def auto_checkin(reservation_number, first_name, last_name, notify=[]): | |||
| r = Reservation(reservation_number, first_name, last_name, notify) | |||
| def auto_checkin(reservation_number, first_name, last_name, notify=[], verbose=False): | |||
There was a problem hiding this comment.
Function auto_checkin has 5 arguments (exceeds 4 allowed). Consider refactoring.
| @@ -10,11 +11,12 @@ | |||
|
|
|||
| class Reservation(): | |||
|
|
|||
| def __init__(self, number, first, last, notifications=[]): | |||
| def __init__(self, number, first, last, notifications=[], verbose=False): | |||
There was a problem hiding this comment.
Function __init__ has 5 arguments (exceeds 4 allowed). Consider refactoring.
|
codeclimate flag will be fixed with new .codeclimate.yml in this PR |
|
Code Climate has analyzed commit c6eecd5 and detected 2 issues on this pull request. Here's the issue category breakdown:
The test coverage on the diff in this pull request is 40.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 86.1%. View more on Code Climate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--verbose switch already existed, but did nothing.
This change causes checkin to print out the raw JSON it receives from southwest, if --verbose is selected.