Skip to content

Commit

Permalink
fix(schedules): linter changes
Browse files Browse the repository at this point in the history
  • Loading branch information
he3als committed Aug 17, 2024
1 parent ecae788 commit c1407c8
Show file tree
Hide file tree
Showing 3 changed files with 29 additions and 23 deletions.
16 changes: 13 additions & 3 deletions resources/scripts/components/elements/ItemContainer.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -4,18 +4,28 @@ import { v4 } from 'uuid';
export interface ContainerProps {
title: string;
description: string;
children: React.ReactNode;
children?: React.ReactNode;
labelClasses?: string;
titleClasses?: string;
descriptionClasses?: string;
divClasses?: string;
}

const ItemContainer = ({ title, description, children, labelClasses, titleClasses, descriptionClasses, divClasses }: ContainerProps) => {
const ItemContainer = ({
title,
description,
children,
labelClasses,
titleClasses,
descriptionClasses,
divClasses,
}: ContainerProps) => {
const uuid = useMemo(() => v4(), []);

return (
<div className={`flex items-center justify-between gap-2 bg-[#3333332a] border-[1px] border-[#ffffff0e] p-4 rounded-lg ${divClasses}`}>
<div
className={`flex items-center justify-between gap-2 bg-[#3333332a] border-[1px] border-[#ffffff0e] p-4 rounded-lg ${divClasses}`}
>
<div className={`flex flex-col ${labelClasses}`}>
<label htmlFor={uuid} className={`text-neutral-300 text-md font-bold ${titleClasses}`}>
{title}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ import { useNavigate, useParams } from 'react-router-dom';

import FlashMessageRender from '@/components/FlashMessageRender';
import Can from '@/components/elements/Can';
import ItemContainer from '@/components/elements/ItemContainer';
import PageContentBlock from '@/components/elements/PageContentBlock';
import Spinner from '@/components/elements/Spinner';
import { Button } from '@/components/elements/button/index';
Expand All @@ -19,10 +20,9 @@ import getServerSchedule from '@/api/server/schedules/getServerSchedule';
import { ServerContext } from '@/state/server';

import useFlash from '@/plugins/useFlash';
import ItemContainer from '@/components/elements/ItemContainer';

const CronBox = ({ title, value }: { title: string; value: string }) => (
<ItemContainer title={title} description={value} children={undefined} />
<ItemContainer title={title} description={value} />
);

const ActivePill = ({ active }: { active: boolean }) => (
Expand Down Expand Up @@ -101,7 +101,7 @@ export default () => {
)}

<br className={`sm:invisible`} />

<strong>Next run at:&nbsp;</strong>
{schedule.nextRunAt ? (
format(schedule.nextRunAt, "MMM do 'at' h:mma")
Expand Down Expand Up @@ -129,16 +129,16 @@ export default () => {
<div>
{schedule.tasks.length > 0
? schedule.tasks
.sort((a, b) =>
a.sequenceId === b.sequenceId ? 0 : a.sequenceId > b.sequenceId ? 1 : -1,
)
.map((task) => (
<ScheduleTaskRow
key={`${schedule.id}_${task.id}`}
task={task}
schedule={schedule}
/>
))
.sort((a, b) =>
a.sequenceId === b.sequenceId ? 0 : a.sequenceId > b.sequenceId ? 1 : -1,
)
.map((task) => (
<ScheduleTaskRow
key={`${schedule.id}_${task.id}`}
task={task}
schedule={schedule}
/>
))
: null}
</div>
</div>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ import { useState } from 'react';

import Can from '@/components/elements/Can';
import ConfirmationModal from '@/components/elements/ConfirmationModal';
import ItemContainer from '@/components/elements/ItemContainer';
import SpinnerOverlay from '@/components/elements/SpinnerOverlay';
import TaskDetailsModal from '@/components/server/schedules/TaskDetailsModal';

Expand All @@ -14,7 +15,6 @@ import { Schedule, Task } from '@/api/server/schedules/getServerSchedules';
import { ServerContext } from '@/state/server';

import useFlash from '@/plugins/useFlash';
import ItemContainer from '@/components/elements/ItemContainer';

interface Props {
schedule: Schedule;
Expand Down Expand Up @@ -98,18 +98,14 @@ export default ({ schedule, task }: Props) => {
<div className={`flex flex-none items-end flex-col sm:flex-row`}>
{task.continueOnFailure && (
<div className={`sm:mr-6`}>
<div
className={`px-2 py-1 bg-yellow-500 text-yellow-800 text-sm rounded-full`}
>
<div className={`px-2 py-1 bg-yellow-500 text-yellow-800 text-sm rounded-full`}>
Continues on Failure
</div>
</div>
)}
{task.sequenceId > 1 && task.timeOffset > 0 && (
<div className={`sm:mr-6`}>
<div className={`px-2 py-1 bg-zinc-500 text-sm rounded-full`}>
{task.timeOffset}s later
</div>
<div className={`px-2 py-1 bg-zinc-500 text-sm rounded-full`}>{task.timeOffset}s later</div>
</div>
)}
<Can action={'schedule.update'}>
Expand Down

0 comments on commit c1407c8

Please sign in to comment.