Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup pyscript web elements #2094

Draft
wants to merge 49 commits into
base: main
Choose a base branch
from
Draft

Conversation

fpliger
Copy link
Contributor

@fpliger fpliger commented Jun 5, 2024

Description

Changes

Checklist

  • All tests pass locally
  • I have updated CHANGELOG.md
  • I have created documentation for this(if applicable)

fpliger and others added 26 commits June 4, 2024 16:27
…a specific selector so it now returns an empty collection
… appending elements.Element or a JsProxy object
@WebReflection
Copy link
Contributor

@fpliger there is a merge conflict but the other one looked OK to me after you rlatest cleanup so I've merged it but I wouldn't know how to resolve those conflicts ... any clue?

@fpliger
Copy link
Contributor Author

fpliger commented Jun 6, 2024

@WebReflection
I made a mistake and opened it towards main instead of pydom_pyweb_to_stdlib (this PR #2092) . We were going to keep #2092 as a gate keeper and were going to merge this and the next couple PR there to not have an instable main . I also didn't put a disclaimer on that PR stating that 🤦 so the PR got merged this morning but doesn't change much....

I'll take care of the conflicts and merge later today and just merge all the next PRs to main.

@WebReflection
Copy link
Contributor

@fpliger I thought you made it back to ready for review (but it was already approved) to have it in ... my bad, I should've waited or asked more ... we just released though, we have time to make changes and fixes ... arguably we could also reverse that merge, that's what git is good at 😉

if you have everything under control though, I let you fix the current state, thanks

@fpliger
Copy link
Contributor Author

fpliger commented Jun 6, 2024

ehehe, no worries at all. My bad really.. we were rushing yesterday evening because it was already late so I ended up forgetting both to mention that in the PR and not opening the other PR towards this one. I'm working on it today with @mchilvers and I hope we can get main to a stable state today or tomorrow the latest. 👍 (== before we release again)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants