-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup pyscript web elements #2094
base: main
Are you sure you want to change the base?
Conversation
…he pyscript.web.dom module
for more information, see https://pre-commit.ci
…into pydom_pyweb_to_stdlib
for more information, see https://pre-commit.ci
…a specific selector so it now returns an empty collection
…into pydom_pyweb_to_stdlib
… appending elements.Element or a JsProxy object
…g nodeList as well
for more information, see https://pre-commit.ci
@fpliger there is a merge conflict but the other one looked OK to me after you rlatest cleanup so I've merged it but I wouldn't know how to resolve those conflicts ... any clue? |
@WebReflection I'll take care of the conflicts and merge later today and just merge all the next PRs to |
@fpliger I thought you made it back to ready for review (but it was already approved) to have it in ... my bad, I should've waited or asked more ... we just released though, we have time to make changes and fixes ... arguably we could also reverse that merge, that's what git is good at 😉 if you have everything under control though, I let you fix the current state, thanks |
ehehe, no worries at all. My bad really.. we were rushing yesterday evening because it was already late so I ended up forgetting both to mention that in the PR and not opening the other PR towards this one. I'm working on it today with @mchilvers and I hope we can get |
Description
Changes
Checklist
CHANGELOG.md