Fix is_masked method on systemd service #569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`systemctl is-enabled my-service` rc is 1 if the service is masked.
philpep
reviewed
Sep 3, 2020
philpep
reviewed
Sep 3, 2020
|
Merged with some simplification of the test. Thanks! This will released as 5.3.1 asap |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi
I'm sorry but I introduced a bug with my PR #568. The
systemcl is-enabledcommand doesn't return 0 when the service is not enabled. So my checkcmd.rc == 0was not relevant in this case.Sorry for this bug. I add on test to check if my code is valid. This time, it should be ok !