-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[cosmwasm] CosmWasm integration with contract manager #1025
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Ignored Deployments
|
These configs are now held in the contract manager
6ec4705
to
fc76d24
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think if we rely on releases we should make sure that the releases cannot be modified easily. Otherwise a single hacked account is enough to cause an incorrect upgrade which can be dangerous. I think relying on builds for our deployment is better.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. I think that relying on releases is dangerous but it was there before (although i think it had hard-coded checksum) so I approve this PR. It's good to discuss it more and if needed fix it in a subsequent PR.
Co-authored-by: Ali Behjati <bahjatia@gmail.com>
No description provided.