Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cosmwasm] CosmWasm integration with contract manager #1025

Merged
merged 6 commits into from
Aug 25, 2023
Merged

Conversation

m30m
Copy link
Collaborator

@m30m m30m commented Aug 23, 2023

No description provided.

@vercel
Copy link

vercel bot commented Aug 23, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
example-oracle-amm ⬜️ Ignored (Inspect) Visit Preview Aug 25, 2023 2:37pm
xc-admin-frontend ⬜️ Ignored (Inspect) Visit Preview Aug 25, 2023 2:37pm

@m30m m30m force-pushed the cosmwasm-cm branch 2 times, most recently from 6ec4705 to fc76d24 Compare August 24, 2023 13:21
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think if we rely on releases we should make sure that the releases cannot be modified easily. Otherwise a single hacked account is enough to cause an incorrect upgrade which can be dangerous. I think relying on builds for our deployment is better.

Copy link
Collaborator

@ali-bahjati ali-bahjati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I think that relying on releases is dangerous but it was there before (although i think it had hard-coded checksum) so I approve this PR. It's good to discuss it more and if needed fix it in a subsequent PR.

Co-authored-by: Ali Behjati <bahjatia@gmail.com>
@m30m m30m merged commit a7d133d into main Aug 25, 2023
7 of 8 checks passed
@m30m m30m deleted the cosmwasm-cm branch August 25, 2023 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants