chore(xc_admin/frontend): set pythnet max publishers to 64 #1305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Ignored Deployments
|
m30m
approved these changes
Feb 20, 2024
guibescos
approved these changes
Feb 20, 2024
ali-bahjati
force-pushed
the
chore/xc-admin/set-pythnet-max-pub
branch
3 times, most recently
from
ed7e718
to
d1c4efd
Compare
ali-bahjati
force-pushed
the
chore/xc-admin/set-pythnet-max-pub
branch
from
d1c4efd
to
6268e7b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
p.s (on the CI fix): Here is my theory: Apparently older forge had some bugs in cloning the dependencies of its own dependencies properly.
ds-testis a dependency offorge-stdthat has some functionalities for testing were new and not really at the version we were using. Now that they've fixed the issue we are facing a problem as the ds-test doesn't have the new functions. I couldn't find relative PR for this though, it's just a guess. I could fix the CI by pinning foundry to an older version but this one is better.