Permit2 sdk #1724
Merged
Permit2 sdk #1724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
m30m
reviewed
Jun 25, 2024
express_relay/sdk/js/src/index.ts
Outdated
| opportunityAdapterInitBytecodeHash: Hex | ||
| ): Address { | ||
| const saltHex = searcher.replace("0x", "").padStart(64, "0"); | ||
| const create2Address = `0x${keccak256( |
There was a problem hiding this comment.
you can use:
https://viem.sh/docs/utilities/getContractAddress
| @@ -164,12 +164,12 @@ export interface components { | |||
| * @description The network chain id parameter for EIP712 domain. | |||
| * @example 31337 | |||
| */ | |||
| chain_id: string; | |||
There was a problem hiding this comment.
why not just remove this EIP712 all together?
| opportunityAdapterConfig.opportunity_adapter_init_bytecode_hash | ||
| ) | ||
| ), | ||
| nonce: bidParams.nonce, |
There was a problem hiding this comment.
nonce should have a default random value. Otherwise, we should document somewhere on what this value should be
danimhr
reviewed
Jun 26, 2024
express_relay/sdk/js/src/index.ts
Outdated
| ): TokenPermissions[] { | ||
| const permitted: TokenPermissions[] = []; | ||
|
|
||
| for (let i = 0; i < tokens.length; i++) { |
danimhr
approved these changes
Jun 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade SDKs to permit2 + factory