Fix wheel tag determination #591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rmarquis I added an optimization for non-poetry (i.e. poetry-core only) builds, some robustness and a smoke test. Please check the changes, especially validate that your use case is still fixed. |
|
@radoering My workflow was impacted by python-poetry/poetry#7957, but once I patched poetry with the proposed fix (along the patched poetry-core) I can confirm everything works correctly now! Thanks for the quick feedback and the above changes, greatly appreaciated! |
|
Kudos, SonarCloud Quality Gate passed!
|
radoering
approved these changes
May 22, 2023
radoering
pushed a commit
to radoering/poetry-core
that referenced
this pull request
May 22, 2023
Co-authored-by: Joshua C. Randall <jcrandall@alum.mit.edu> Co-authored-by: Randy Döring <30527984+radoering@users.noreply.github.com> (cherry picked from commit 5da9a2e)
This was referenced May 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: python-poetry#3509
This is a follow-up of PR #227, based on the work of @jrandall rebased on latest stable version, squashed and cleaned up, with the addition of requested changes by @radoering.
As @jrandall is seemingly unresponsive, this is an attempt at getting his work merged in poetry-core. All credits to him.
As suggested in #227, the initial PR is divided in 2 parts:
All tests are passing. I guess @radoering would like to review as he commenetd on past iteration of this change.