Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pre commit hook #85

Merged
merged 1 commit into from
Sep 6, 2022
Merged

Pre commit hook #85

merged 1 commit into from
Sep 6, 2022

Conversation

dimbleby
Copy link
Contributor

@dimbleby dimbleby commented Jul 9, 2022

python-poetry/poetry#5980 removed this from poetry, here's a replacement

@sonarcloud
Copy link

sonarcloud bot commented Jul 9, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sonarcloud
Copy link

sonarcloud bot commented Aug 13, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@dimbleby
Copy link
Contributor Author

dimbleby commented Aug 13, 2022

NB whether or not we remove the circular dependency per python-poetry/poetry#5980, it makes sense for this repository to be the one that provides the precommit hook

@neersighted
Copy link
Member

I wonder if it's productive to add a stub hook upstream -- something like echo "This hook has moved! See <issue link> to migrate." && exit 1

@neersighted neersighted merged commit d186c95 into python-poetry:main Sep 6, 2022
@dimbleby dimbleby deleted the pre-commit-hook branch September 7, 2022 07:57
@radoering radoering mentioned this pull request Sep 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants