Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exclude nested items (#784) #1464

Merged
merged 14 commits into from
Oct 19, 2019
Merged

Exclude nested items (#784) #1464

merged 14 commits into from
Oct 19, 2019

Commits on Oct 14, 2019

  1. This PR impliments the feature request python-poetry#784. 

    When a folder is explicit defined in `pyproject.toml` as excluded, all nested data, including subfolder, are excluded. It is no longer neccessary to use the glob `folder/**/*`
    Tobias Klare committed Oct 14, 2019
    Configuration menu
    Copy the full SHA
    9982b09 View commit details
    Browse the repository at this point in the history

  2. use Path instead of os.path.join to create string for globbing

    Tobias Klare committed Oct 14, 2019
    Configuration menu
    Copy the full SHA
    35603ac View commit details
    Browse the repository at this point in the history

  3. try to fix linting error

    Tobias Klare committed Oct 14, 2019
    Configuration menu
    Copy the full SHA
    0834f78 View commit details
    Browse the repository at this point in the history

  4. create glob pattern string by concatenating and not using Path

    Tobias Klare committed Oct 14, 2019
    Configuration menu
    Copy the full SHA
    e5e125a View commit details
    Browse the repository at this point in the history

  5. using os.path.isdir()` for checking of explicit excluded name is a … 

    …folder, because pathlib's `is_dir()` raises in exception under windows of name contains globing characters
    Tobias Klare committed Oct 14, 2019
    Configuration menu
    Copy the full SHA
    1df49c8 View commit details
    Browse the repository at this point in the history

Commits on Oct 15, 2019

  1. Remove nested data when wildcards where used. 

    Steps to do this are:
1. expand any wildcard used
2. if expanded path is a folder append  **/* and expand again
    finswimmer77@gmail.com authored and finswimmer77@gmail.com committed Oct 15, 2019
    Configuration menu
    Copy the full SHA
    56868de View commit details
    Browse the repository at this point in the history

  2. fix linting

    finswimmer77@gmail.com authored and finswimmer77@gmail.com committed Oct 15, 2019
    Configuration menu
    Copy the full SHA
    a8a9c5d View commit details
    Browse the repository at this point in the history

  3. fix linting error

    finswimmer77@gmail.com authored and finswimmer77@gmail.com committed Oct 15, 2019
    Configuration menu
    Copy the full SHA
    42693ca View commit details
    Browse the repository at this point in the history

  4. only glob a second time if path is dir

    finswimmer77@gmail.com authored and finswimmer77@gmail.com committed Oct 15, 2019
    Configuration menu
    Copy the full SHA
    ce576c7 View commit details
    Browse the repository at this point in the history

Commits on Oct 18, 2019

  1. implement @sdispater 's suggestion for better readability

    finswimmer77@gmail.com authored and finswimmer77@gmail.com committed Oct 18, 2019
    Configuration menu
    Copy the full SHA
    1cd93bd View commit details
    Browse the repository at this point in the history

  2. fix glob for windows?

    finswimmer77@gmail.com authored and finswimmer77@gmail.com committed Oct 18, 2019
    Configuration menu
    Copy the full SHA
    fa8c04f View commit details
    Browse the repository at this point in the history

Commits on Oct 19, 2019

  1. On Windows, testing if a path with a glob is a directory will raise a… 

    …n OSError
    finswimmer77@gmail.com authored and finswimmer77@gmail.com committed Oct 19, 2019
    Configuration menu
    Copy the full SHA
    09af714 View commit details
    Browse the repository at this point in the history

  2. pathlibs glob function doesn't return the correct case (https://bugs.… 

    …python.org/issue26655). So switching back to  glob.glob()
    finswimmer77@gmail.com authored and finswimmer77@gmail.com committed Oct 19, 2019
    Configuration menu
    Copy the full SHA
    5617921 View commit details
    Browse the repository at this point in the history

  3. removing obsolete imports

    finswimmer77@gmail.com authored and finswimmer77@gmail.com committed Oct 19, 2019
    Configuration menu
    Copy the full SHA
    38ed4d6 View commit details
    Browse the repository at this point in the history