Standardise on using virtualenv package #2666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Until now poetry used the built-in venv module available in Python 3. This has presented a few concerns. Chief of which has been inconsistent environment setup. This includes, but is not limited to, pip version used by the `ensurepip` module which is in turn used by the built-in `venv.EnvBuilder`. Additionally, the `virtualenv` package allows for faster environment creation. This can also allow us to, going forward, drop ad-hoc code required to inspect and manage environments.
3 tasks
This was
linked to
issues
Jul 21, 2020
Merged
2 tasks
This was referenced Aug 16, 2020
This was referenced Sep 23, 2020
2 tasks
3 tasks
3 tasks
2 tasks
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Until now poetry used the built-in venv module available in Python 3.
This has presented a few concerns. Chief of which has been
inconsistent environment setup. This includes, but is not limited to,
pip version used by the
ensurepipmodule which is in turn used by thebuilt-in
venv.EnvBuilder. Additionally, thevirtualenvpackageallows for faster environment creation. This can also allow us to, going
forward, drop ad-hoc code required to inspect and manage environments.
See also: #2650
Closes: #732