Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds File existence check to Uploader #4417

Conversation

1nF0rmed
Copy link
Contributor

@1nF0rmed 1nF0rmed commented Aug 20, 2021

This handles the TODO for checking the existence of the files being
uploaded by the Uploader class.

# TODO: Check existence

In the case that a file does not exist, it raises a UploadError.

The raised error message is as follows:
Wheel or Tar files associated with the Project Package do not exist

Pull Request Check List

Resolves: NA

  • Added tests for changed code.
  • Updated documentation for changed code. [NA]

Questions:

  • At the moment, the error message being shown is pretty generic. Should I be specific with the file that could not be found?

@finswimmer finswimmer requested a review from a team August 26, 2021 18:09
@1nF0rmed
Copy link
Contributor Author

@finswimmer Please can you review my PR?

abn
abn previously requested changes Oct 8, 2021
poetry/publishing/uploader.py Outdated Show resolved Hide resolved
poetry/publishing/uploader.py Outdated Show resolved Hide resolved
@neersighted
Copy link
Member

Could you rebase onto master and implement @abn's feedback? Thanks!

@neersighted neersighted self-assigned this Nov 15, 2021
@1nF0rmed
Copy link
Contributor Author

Sure - I'll rebase this and update to match the suggestions :)

@neersighted
Copy link
Member

neersighted commented Nov 15, 2021

Looks like a bad rebase. I'd suggest reverting using your reflog, fetching upstream and rebasing onto upstream/master.

@1nF0rmed 1nF0rmed force-pushed the adds_check_file_existence_to_uploader branch from 7f9726d to 9e0135b Compare November 15, 2021 06:44
@1nF0rmed 1nF0rmed force-pushed the adds_check_file_existence_to_uploader branch from 9e0135b to 1fd7832 Compare November 15, 2021 07:52
neersighted
neersighted previously approved these changes Sep 18, 2022
@neersighted neersighted enabled auto-merge (squash) September 18, 2022 06:15
@neersighted neersighted added this to the 1.3 milestone Sep 18, 2022
@neersighted neersighted added impact/changelog Requires a changelog entry area/uploader Related to the repository uploader kind/enhancement Not a bug or feature, but improves usability or performance labels Sep 18, 2022
@neersighted
Copy link
Member

pre-commit.ci autofix

neersighted
neersighted previously approved these changes Sep 18, 2022
This handles the TODO for checking the existence of the files being
uploaded by the Uploader class.
In the case that a file does not exist, it raises an UploadError.

Co-authored-by: Bjorn Neergaard <bjorn@neersighted.com>
@neersighted neersighted force-pushed the adds_check_file_existence_to_uploader branch from cd8457f to 085a5ee Compare September 18, 2022 07:00
@neersighted neersighted merged commit 83e6bbb into python-poetry:master Sep 18, 2022
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area/uploader Related to the repository uploader impact/changelog Requires a changelog entry kind/enhancement Not a bug or feature, but improves usability or performance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants