Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misc. changes to support upcoming changes to poetry-core #4604

Merged
merged 4 commits into from
Oct 8, 2021

Conversation

abn
Copy link
Member

@abn abn commented Oct 6, 2021

This change handles various issues in provider code and tests to ensure upstream poetry-core@master CI passes.

@abn abn changed the title Misc. changes to support upcoming breaking changes to poetry-core Misc. changes to support upcoming changes to poetry-core Oct 6, 2021
This change ensures that python_version comparison uses parsed versions
and does not fail with changes in pretty output.
This change ensures that the tests support upcoming (>1.1.0a6) changes
dropping default branch assumptions for vcs dependencies.
This change ensures that when complete packages are created dependency
inherits source and resolved refs from package.
This change ensures that when complete packages are created dependency
inherits subdirectory from package if supported.
Copy link
Member

@kasteph kasteph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🌴

tests/puzzle/test_solver.py Show resolved Hide resolved
@abn abn merged commit 0761aa7 into python-poetry:master Oct 8, 2021
@abn abn deleted the fix/upstream-core-ci branch October 8, 2021 12:28
@finswimmer finswimmer mentioned this pull request Mar 17, 2022
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants