Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change keyring dependency to >=21.2.0 #5041

Merged
merged 1 commit into from
Jan 17, 2022
Merged

Conversation

NeilGirdhar
Copy link
Contributor

No description provided.

@NeilGirdhar
Copy link
Contributor Author

This is a backport of #4003

@neersighted neersighted merged commit c61bc9c into python-poetry:1.1 Jan 17, 2022
@davegaeddert
Copy link
Contributor

Just FYI, I think I hit a potential issue related to this in the 1.1.3 release: #5189 (comment)

@davegaeddert
Copy link
Contributor

(Actually it applies to the upcoming 1.2.0 series too, according to my tests)

@NeilGirdhar
Copy link
Contributor Author

@davegaeddert Can you help me understand why this works with old version, but not the new one?

@davegaeddert
Copy link
Contributor

@NeilGirdhar sure thing — I learned a little more about it over the weekend. Basically in keyring v23.2.0 they added a backend for "libsecret" and I think the short answer is that, in a specific environment, it makes it seem like an available backend but then it throws an error when you actually use it. I think it's for them to fix (I opened an issue and a PR to add a failing test, but not sure what the fix is yet). The environment where you hit the error is essentially a headless linux, where Poetry is installed alongside the the "gi" package (ex. import gi). In GitHub Actions, if you do a basic setup like this then you hit the error:

on: push

jobs:
  test:
    runs-on: ubuntu-latest
    steps:
    - uses: actions/checkout@v2
    - run: pip3 install -U pip poetry

Let me know what you think.

@NeilGirdhar
Copy link
Contributor Author

@davegaeddert Awesome! Thanks for getting the ball rolling with such a well-described issue, and explanation here.

Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants