Solver fixes #5305
Merged
Solver fixes #5305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dimbleby
force-pushed
the
solver-fixes
branch
2 times, most recently
from
66fed3d
to
96d59cd
Compare
|
(I have rearranged my branches so that this MR contains only the fix, and the refactoring is in #5309) |
Merged
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Check List
Resolves: #4683
Resolves: #5019
A series of commits tidying up the depth-first search in the solver, and a fix for #4683 (and its duplicate #5019)
seenon thePackageNodeshould clearly be a set rather than a list, for efficient lookupvisitedin the search, and should be removed altogether... maybe another time)visitedin the search was strangely and unnecessarily complicated, I made it normaldfs_visit()always returnedTrue; it has no need of a return value at allA testcase and fix for Poetry cannot install dvc[ssh] package #4683: in the language of the added testcase, the fix is to make sure that we visit both
BandB[bar]in the search