feat: update poetry-core via poetry self update #5306
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
finswimmer
force-pushed
the
self-update-core
branch
4 times, most recently
from
cd981c9
to
48906b8
Compare
finswimmer
force-pushed
the
self-update-core
branch
from
48906b8
to
e21536f
Compare
finswimmer
changed the title
neersighted
requested changes
May 18, 2022
| ] | ||
|
|
||
| if not update_releases: | ||
| self.line("You are using the latest version") |
There was a problem hiding this comment.
Suggested change
| self.line("You are using the latest version") | |
| self.line("You are already using the latest version.") |
| f"<c1>{release.pretty_name}</c1> to <c2>{release.version}</c2>" | ||
| for release in update_releases | ||
| ] | ||
| self.line(f"Updating {' and '.join(msg)}.") |
There was a problem hiding this comment.
Suggested change
| self.line(f"Updating {' and '.join(msg)}.") | |
| self.line(f"Updating {', '.join(msg)}.") |
| self._make_bin() | ||
|
|
||
| self.line("") | ||
| self.line(f"Successfully updated {' and '.join(msg)}. Great!") |
There was a problem hiding this comment.
Suggested change
| self.line(f"Successfully updated {' and '.join(msg)}. Great!") | |
| self.line(f"Successfully updated {', '.join(msg)}!") |
| if dependency.name == "poetry-core": | ||
| if core and not dependency.constraint.allows(Version.parse(core)): | ||
| raise PoetrySimpleConsoleException( | ||
| f"poetry-core {core} is not supported by poetry" |
There was a problem hiding this comment.
Suggested change
| f"poetry-core {core} is not supported by poetry" | |
| f"poetry-core {core} is not supported by Poetry" |
| break | ||
| else: | ||
| raise PoetrySimpleConsoleException( | ||
| "No compatible version of poetry-core for poetry" |
There was a problem hiding this comment.
Suggested change
| "No compatible version of poetry-core for poetry" | |
| "No compatible version of poetry-core for Poetry" |
| version = self.argument("version") | ||
| if not version: | ||
| version = ">=" + __version__ | ||
| is_prerelease = Version.parse(metadata.version("poetry")).is_prerelease() | ||
| version = ">=" + metadata.version("poetry") |
There was a problem hiding this comment.
Use str.format() here -- it's a bit more readable.
| version = ">=" + metadata.version("poetry") | ||
|
|
||
| release = self._find_release( | ||
| "poetry", version, is_prerelease or self.option("preview") |
There was a problem hiding this comment.
Please use these as kwargs for readability.
| f" {poetry_release.version}." | ||
| ) | ||
|
|
||
| core_release = self._find_release("poetry-core", core, True) |
|
|
||
| env = EnvManager.get_system_env(naive=True) | ||
|
|
||
| # We can't use is_relative_to() since it's only available in Python 3.9+ |
There was a problem hiding this comment.
This comment could be a little more descriptive -- we're throwing away the result of the env.path call because it throws an exception when the paths are not adjacent, right?
|
Closing in favor of #5450 |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running
poetry self updatenow updates to a newpoetry-corerelease, even if there is no newpoetryrelease.Via a new parameter
--coreit is possible to define a specific version ofpoetry-coreto update to.Furthermore
poetry self updatenow updates to a newpoetrypre-release version, if the current installed version is a pre-release version as well.Pull Request Check List
Resolves: #issue-number-here