add progress to download_file if in Indicator context
#5451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgolsson
force-pushed
the
ts/progress-bar-download-file
branch
from
16bbee0
to
9a02849
Compare
abn
reviewed
Apr 15, 2022
abn
reviewed
Apr 15, 2022
Co-authored-by: Arun Babu Neelicattu <arun.neelicattu@gmail.com>
tgolsson
force-pushed
the
ts/progress-bar-download-file
branch
from
7f730ae
to
8b636a6
Compare
Closed
Closed
neersighted
previously approved these changes
May 18, 2022
neersighted
approved these changes
May 18, 2022
Merged
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Check List
No meaningful documentation to add and hard to test a progress-bar.
Resolves: #999
This code adds a context field for the Indicator that can be used for download_file.
This has to be integrated with the
Indicatorto synchronize the output, otherwise it leads to corruption/racey output sinceProgressIndicator.autowrites from a second thread.Based on that requirement I opted to use a class field to store this context, as otherwise almost every function involved in dependency resolution got an
indicatorargument to feed it todownload_file. This felt extremely noisy, and also hit some circular imports.