config: rework eval order and respect env vars #5672
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Secrus
requested changes
May 23, 2022
This change ensures that we respect `POETRY_CONFIG_DIR` as well as ensure environment variables are respected for `POETRY_CACHE_DIR`. This change also fixes an issue with repository cache directories not respecting base cache directory configuration changes.
Secrus
approved these changes
May 23, 2022
neersighted
approved these changes
May 23, 2022
Merged
2 tasks
3 tasks
This was referenced Jun 3, 2022
Merged
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change ensures that we respect
POETRY_CONFIG_DIRas well asensure environment variables are respected for
POETRY_CACHE_DIR.This change also fixes an issue with repository cache directories not
respecting base cache directory configuration changes.
Resolves: #2445
Closes: #5301