Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cover edge case when environment is being created with empty project name #5856

Merged
merged 4 commits into from
Aug 15, 2022

Conversation

Secrus
Copy link
Member

@Secrus Secrus commented Jun 15, 2022

Pull Request Check List

Resolves: #5794

  • Added tests for changed code.
  • Updated documentation for changed code.

@Secrus Secrus force-pushed the fix-venv-prompt branch 3 times, most recently from 3d49a5c to 5601486 Compare August 8, 2022 22:42
@Secrus Secrus marked this pull request as ready for review August 8, 2022 23:04
@Secrus Secrus requested a review from a team August 8, 2022 23:05
@Secrus Secrus changed the title Use new method to get formatted prompt for virtualenv Cover edge case when environment is being created with empty project name Aug 8, 2022
@radoering radoering merged commit a896884 into python-poetry:master Aug 15, 2022
@Secrus Secrus deleted the fix-venv-prompt branch August 25, 2022 11:12
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Creating new virtualenv fails with cryptic error for project with empty name
2 participants