Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

every Repository is named #5910

Merged
merged 2 commits into from
Jul 13, 2022
Merged

every Repository is named #5910

merged 2 commits into from
Jul 13, 2022

Conversation

dimbleby
Copy link
Contributor

Per the FIXME that is removed by this MR, nameless repositories are undesirable because they'll confuse aPool of repositories.

I've made sure that all repositories are named:

  • sometimes by giving repositories somewhat artificial names, but always "poetry-" something so as to make clashes with user-defined repositories unlikely
  • sometimes by recognising that where we were using a nameless repository, all that we really needed was a list of packages.

@dimbleby dimbleby mentioned this pull request Jun 25, 2022
Merged
@dimbleby
Copy link
Contributor Author

ugh, tests failing because of poetry-export-plugin, see python-poetry/poetry-plugin-export#79

@dimbleby dimbleby force-pushed the named-repositories branch 2 times, most recently from 74106df to 5bbd7b4 Compare June 25, 2022 17:51
radoering
radoering previously approved these changes Jun 26, 2022
View reviewed changes
Copy link
Member

@radoering radoering left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New release of poetry-plugin-export required for tests to pass.

@dimbleby
Copy link
Contributor Author

New release of poetry-plugin-export required for tests to pass.

indeed. Also #5711, #5819 are even more tangled (and #5711 also needs poetry-core to be released before it can progress).

Cross-repository testing is awkward.

@dimbleby
Copy link
Contributor Author

release of export plugin 1.0.5 should give us green pipelines here and allow this to merge

@neersighted neersighted merged commit c2c69a3 into python-poetry:master Jul 13, 2022
@dimbleby dimbleby deleted the named-repositories branch July 13, 2022 09:09
@mkniewallner mkniewallner mentioned this pull request Jul 13, 2022
Merged
@github-actions GitHub Actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@neersighted neersighted neersighted approved these changes

@radoering radoering radoering left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dimbleby @neersighted @radoering