Fasten the excluded file check #604
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before we build a potentially very big list of all the excluded file matching every exclude pattern, which could be a lot and then do a containment check on the resulting list. A first step to speed up the process is to returns a set instead of a list so containment checks will not be dependent to the number of matching files anymore. If the set still ends up being too large, introducing an intermediary solution that check if a file name match a glob pattern instead of expanding the glob pattern might be a good solution. Right now, it seems overkill in comparison of this patch. With this patch, building my project that exclude `nodes_modules/**/*` went from 4 minutes to 7 seconds. Fix python-poetry#603
|
Thanks! For now I agree this is enough as a quick fix for the issue. |
|
Thank you for merging this PR, the build is likely failing because of Teemu/pytest-sugar#159, I wanted to send a PR for forcing an older of pytest, but didn't had time at the moment |
|
Easier than pinning an older pytest is to add the workaround |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before we build a potentially very big list of all the excluded file matching
every exclude pattern, which could be a lot and then do a containment check on
the resulting list.
A first step to speed up the process is to returns a set instead of a list so
containment checks will not be dependent to the number of matching files
anymore.
If the set still ends up being too large, introducing an intermediary solution
that check if a file name match a glob pattern instead of expanding the glob
pattern might be a good solution. Right now, it seems overkill in comparison
of this patch.
With this patch, building my project that exclude
nodes_modules/**/*wentfrom 4 minutes to 7 seconds.
Fix #603
Pull Request Check List
This is just a reminder about the most common mistakes. Please make sure that you tick all appropriate boxes. But please read our contribution guide at least once, it will save you unnecessary review cycles!
Note: If your Pull Request introduces a new feature or changes the current behavior, it should be based
on the
developbranch. If it's a bug fix or only a documentation update, it should be based on themasterbranch.If you have any questions to any of the points above, just submit and ask! This checklist is here to help you, not to deter you from contributing!