poc: foreign pip #6458
Closed
poc: foreign pip #6458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
After discussion with pip devs, pypa/pip#11320 is merged and will be released soon, and will allow this to go forward without any of the drawbacks (having to gather wheel tags/not getting scripts) as we can just pass the path to the target interpreter to pip. |
This was referenced Sep 18, 2022
Merged
|
Since we now have |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a take on an alternate solution to our current embedded/in-venv pip woes: use a 'foreign' pip installed in Poetry's env to manage files in the project venv.
This works, except for scripts as
--targetdoes not install scripts properly, and--prefixcannot be used with the wheel platform overrides. However, if pip grows support for--prefixinstead of--targetin our use case, this could be a viable transitional approach for 1.2.Tests are going to be totally busted as I have not upgraded any of them for the new code yet.