fix: don't merge sources into config #7560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radoering
force-pushed
the
keep-config-and-sources-separated
branch
from
76f332d
to
bcb9bda
Compare
dimbleby
reviewed
Feb 25, 2023
radoering
force-pushed
the
keep-config-and-sources-separated
branch
from
bcb9bda
to
3ea0a49
Compare
|
I added a test that fails without this fix. (That's how I noticed the issue in the first place.) |
neersighted
approved these changes
Feb 27, 2023
2 tasks
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug introduced via 55127c8 in #6205. Merging the sources from pyproject.toml into the global configuration implicitly allows to define sources globally (in an unintuitive way, but nevertheless...), which was surely not intended.
Instead of merging sources into the global config and creating a new repository pool for each install of an sdist from the global config, we can just reuse the pool passed to the executor. This should be a minor performance improvement.