Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove stdout=subprocess.PIPE from env._call, see #7698 #7699

Merged
merged 3 commits into from
Mar 23, 2023

Conversation

fzahle
Copy link
Contributor

@fzahle fzahle commented Mar 21, 2023

Pull Request Check List

Resolves: #7698

  • Added tests for changed code.
  • Updated documentation for changed code.

I have zero insight in the code base and unfortunately can't see how I would add a test for this fix. But a minimal example can be found here https://gist.github.com/fzahle/3f0ae0237b325e736246bd467e56e6d5, that could be the basis for a test.

@fzahle
Copy link
Contributor Author

fzahle commented Mar 21, 2023

pre-commit.ci autofix

@radoering radoering added area/installer Related to the dependency installer impact/backport Requires backport to stable branch backport/1.4 labels Mar 22, 2023
@radoering radoering merged commit fa5543a into python-poetry:master Mar 23, 2023
poetry-bot bot pushed a commit that referenced this pull request Mar 23, 2023
…install to hang (#7699)

Co-authored-by: Randy Döring <30527984+radoering@users.noreply.github.com>
(cherry picked from commit fa5543a)
radoering pushed a commit that referenced this pull request Mar 23, 2023
…install to hang (#7699)

Co-authored-by: Randy Döring <30527984+radoering@users.noreply.github.com>
(cherry picked from commit fa5543a)
adriangb pushed a commit to adriangb/poetry that referenced this pull request Apr 5, 2023
…install to hang (python-poetry#7699)

Co-authored-by: Randy Döring <30527984+radoering@users.noreply.github.com>
Copy link

github-actions bot commented Mar 3, 2024

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area/installer Related to the dependency installer impact/backport Requires backport to stable branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Python extensions that print very long build logs to stdout causes poetry install to hang
2 participants