Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

warn when overwriting file at installation #8386

Merged
merged 2 commits into from
Sep 11, 2023
Merged

warn when overwriting file at installation #8386

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4e85763
warn when overwriting file at installation
dimbleby Aug 30, 2023
2dc3916
Merge branch 'master' into wheel-install-warn-overwrite
Secrus Sep 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/poetry/installation/wheel_installer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
from __future__ import annotations

import logging
import platform
import sys

Expand All @@ -15,6 +16,8 @@
from poetry.utils._compat import WINDOWS


logger = logging.getLogger(__name__)

if TYPE_CHECKING:
from collections.abc import Collection
from typing import BinaryIO
Expand Down Expand Up @@ -45,7 +48,7 @@ def write_to_fs(
if target_path.exists():
# Contrary to the base library we don't raise an error here since it can
# break pkgutil-style and pkg_resource-style namespace packages.
pass
logger.warning(f"Installing {target_path} over existing file")

parent_folder = target_path.parent
if not parent_folder.exists():
Expand Down