inspection: error on unsupported metadata versions

src/poetry/inspection/info.py

@@ -266,6 +266,11 @@ def _from_distribution(
 
         :param dist: The distribution instance to parse information from.
         """
+        if dist.metadata_version not in pkginfo.distribution.HEADER_ATTRS:
+            # This check can be replaced once upstream implements strict parsing
+            # https://bugs.launchpad.net/pkginfo/+bug/2058697
+            raise ValueError("Unknown metadata version")
+
         requirements = cls._requirements_from_distribution(dist)
 
         info = cls(
@@ -545,8 +550,8 @@ def from_wheel(cls, path: Path) -> PackageInfo:
         try:
             wheel = pkginfo.Wheel(str(path))
             return cls._from_distribution(wheel)
-        except ValueError:
-            return PackageInfo()
+        except ValueError as e:
+            raise PackageInfoError(path, e)
 
     @classmethod
     def from_bdist(cls, path: Path) -> PackageInfo:

tests/inspection/test_info.py

@@ -199,6 +199,20 @@ def test_info_from_wheel_metadata_version_23(fixture_dir: FixtureDirGetter) -> N
     assert info._source_url == path.resolve().as_posix()
 
 
+def test_info_from_wheel_metadata_version_unknown(
+    fixture_dir: FixtureDirGetter,
+) -> None:
+    path = (
+        fixture_dir("distributions")
+        / "demo_metadata_version_unknown-0.1.0-py2.py3-none-any.whl"
+    )
+
+    with pytest.raises(PackageInfoError) as e:
+        PackageInfo.from_wheel(path)
+
+    assert "Unknown metadata version" in str(e.value)
+
+
 def test_info_from_wheel_metadata(demo_wheel_metadata: RawMetadata) -> None:
     info = PackageInfo.from_metadata(demo_wheel_metadata)
     demo_check_info(info)

tests/repositories/test_http_repository.py

@@ -1,5 +1,6 @@
 from __future__ import annotations
 
+import contextlib
 import shutil
 
 from pathlib import Path
@@ -12,6 +13,7 @@
 from packaging.metadata import parse_email
 from poetry.core.packages.utils.link import Link
 
+from poetry.inspection.info import PackageInfoError
 from poetry.inspection.lazy_wheel import HTTPRangeRequestUnsupported
 from poetry.repositories.http_repository import HTTPRepository
 from poetry.utils.helpers import HTTPRangeRequestSupported
@@ -116,41 +118,57 @@ def test_get_info_from_wheel_state_sequence(mocker: MockerFixture) -> None:
 
     # 1. range request and download
     mock_metadata_from_wheel_url.side_effect = HTTPRangeRequestUnsupported
-    repo._get_info_from_wheel(link)
+
+    with contextlib.suppress(PackageInfoError):
+        repo._get_info_from_wheel(link)
+
     assert mock_metadata_from_wheel_url.call_count == 1
     assert mock_download.call_count == 1
     assert mock_download.call_args[1]["raise_accepts_ranges"] is False
 
     # 2. only download
-    repo._get_info_from_wheel(link)
+    with contextlib.suppress(PackageInfoError):
+        repo._get_info_from_wheel(link)
+
     assert mock_metadata_from_wheel_url.call_count == 1
     assert mock_download.call_count == 2
     assert mock_download.call_args[1]["raise_accepts_ranges"] is True
 
     # 3. download and range request
     mock_metadata_from_wheel_url.side_effect = None
     mock_download.side_effect = HTTPRangeRequestSupported
-    repo._get_info_from_wheel(link)
+
+    with contextlib.suppress(PackageInfoError):
+        repo._get_info_from_wheel(link)
+
     assert mock_metadata_from_wheel_url.call_count == 2
     assert mock_download.call_count == 3
     assert mock_download.call_args[1]["raise_accepts_ranges"] is True
 
     # 4. only range request
-    repo._get_info_from_wheel(link)
+    with contextlib.suppress(PackageInfoError):
+        repo._get_info_from_wheel(link)
+
     assert mock_metadata_from_wheel_url.call_count == 3
     assert mock_download.call_count == 3
 
     # 5. range request and download
     mock_metadata_from_wheel_url.side_effect = HTTPRangeRequestUnsupported
     mock_download.side_effect = None
-    repo._get_info_from_wheel(link)
+
+    with contextlib.suppress(PackageInfoError):
+        repo._get_info_from_wheel(link)
+
     assert mock_metadata_from_wheel_url.call_count == 4
     assert mock_download.call_count == 4
     assert mock_download.call_args[1]["raise_accepts_ranges"] is False
 
     # 6. only range request
     mock_metadata_from_wheel_url.side_effect = None
-    repo._get_info_from_wheel(link)
+
+    with contextlib.suppress(PackageInfoError):
+        repo._get_info_from_wheel(link)
+
     assert mock_metadata_from_wheel_url.call_count == 5
     assert mock_download.call_count == 4