Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevents TOMLFile from changing line endings #149

Merged
merged 6 commits into from
Dec 17, 2021

Conversation

utek
Copy link
Contributor

@utek utek commented Nov 17, 2021

I think that line endings should be preserved and not changed
to system ones when reading and saving the file.

Lukasz Boldys added 2 commits November 17, 2021 15:37
I think that line endings should be preserved and not changed
to system ones when reading and saving the file.
@abn
Copy link
Member

abn commented Nov 18, 2021

@sdispater can you review this please?

Relates-to: python-poetry/poetry#2993

@utek
Copy link
Contributor Author

utek commented Nov 18, 2021

@sdispater I've modified the poetry install in the workflow -> 359e9c4 I think the preview version of poetry can't be installed this way (according to error msg)

.github/workflows/tests.yml Outdated Show resolved Hide resolved
@frostming
Copy link
Contributor

Thanks

@frostming frostming merged commit f80428c into python-poetry:master Dec 17, 2021
@utek
Copy link
Contributor Author

utek commented Dec 17, 2021

@frostming Thank you

@utek utek deleted the dont_modify_newlines branch February 18, 2022 10:06
capuanob pushed a commit to capuanob/tomlkit that referenced this pull request Mar 1, 2023
Prevents TOMLFile from changing line endings
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants