Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip test_apply_mask_non_contiguous_memoryview on PyPy #1158

Closed
aaugustin opened this issue Apr 8, 2022 · 0 comments
Closed

Skip test_apply_mask_non_contiguous_memoryview on PyPy #1158

aaugustin opened this issue Apr 8, 2022 · 0 comments

Comments

@aaugustin
Copy link
Member

As discussed in #1157.
@aaugustin aaugustin mentioned this issue Apr 8, 2022
Closed
mgorny added a commit to mgorny/websockets that referenced this issue Apr 8, 2022
@mgorny
Skip non-contiguous buffer tests on NotImplementedError (pypy)
09f07a4 
PyPy3.9 7.3.9 does not implement creating contiguous buffers from
non-contiguous, causing the respective tests to fail due to
NotImplementedError.  Catch it and skip the tests appropriately
as discussed in python-websockets#1157.

Fixes python-websockets#1158
aaugustin pushed a commit that referenced this issue Apr 17, 2022
@mgorny @aaugustin
Skip non-contiguous buffer tests on NotImplementedError (pypy)
bdc8e9f 
PyPy3.9 7.3.9 does not implement creating contiguous buffers from
non-contiguous, causing the respective tests to fail due to
NotImplementedError.  Catch it and skip the tests appropriately
as discussed in #1157.

Fixes #1158
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@aaugustin