Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebSocketProtocolError is no longer exposed #649

Closed
Harmon758 opened this issue Jul 15, 2019 · 1 comment · Fixed by #650
Closed

WebSocketProtocolError is no longer exposed #649

Harmon758 opened this issue Jul 15, 2019 · 1 comment · Fixed by #650

Comments

@Harmon758
Copy link
Contributor

The changelog for 8.0 says:

Version 8.0 renames the WebSocketProtocolError exception to :exc:ProtocolError .

A WebSocketProtocolError alias provides backwards compatibility.

However, WebSocketProtocolError is no longer exposed:

>>> import websockets
>>> websockets.WebSocketProtocolError
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
AttributeError: module 'websockets' has no attribute 'WebSocketProtocolError'

and this change breaks backwards compatibility.

@aaugustin
Copy link
Member

Thanks, I'll make a bugfix release with this fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants