gh-100445: Improve error message for unterminated strings with escapes #100446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
hauntsaninja
commented
Dec 23, 2022
•
hauntsaninja
commented
- Issue: Improve error message for unterminated strings with escapes #100445
|
This is in my queue ;) Will review it as soon as I am back from vacation |
|
(This might conflict with PEP 701 changes, in which case feel free to close it) |
|
Yeah, let's wait until PEP 701 gets a decision to know what to do here 👍 |
hauntsaninja
force-pushed
the
gh-100445
branch
from
c848f39
to
a844eaf
Compare
hauntsaninja
force-pushed
the
gh-100445
branch
from
78ca307
to
4fb56c9
Compare
|
Coming back to this, rebased on top of latest main :-) |
|
I've fixed the merge conflicts again! |
|
Great job @hauntsaninja! Thanks for the patience! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.