gh-102038: Skip a sometimes unnecessary stat in site.py #102039
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eendebakpt
reviewed
Mar 21, 2023
| @@ -0,0 +1 @@ | |||
| Skip a ``stat`` in :mod:`site` if we have already found a ``pyvenv.cfg`` | |||
There was a problem hiding this comment.
With stat you mean the os.path.isfile check that is skipped? I am unfamiliar with the term, but from the news entry alone I did not understand this.
There was a problem hiding this comment.
Yeah, an unnecessary os.path.isfile is skipped. "stat" here comes from the name of the syscall: https://en.wikipedia.org/wiki/Stat_(system_call)
gaogaotiantian
pushed a commit
to gaogaotiantian/cpython
that referenced
this pull request
Apr 8, 2023
warsaw
pushed a commit
to warsaw/cpython
that referenced
this pull request
Apr 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I also changed the
exe_dirassignment to useos.path.dirname. This is exactly equivalent toos.path.split(...)[0]; the only reason we usedsplitwas refactoring in 27e4b60