Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-30455: Generate all token related code and docs from Grammar/Tokens. #10370

Merged
merged 25 commits into from
Dec 22, 2018

Conversation

serhiy-storchaka
Copy link
Member

@serhiy-storchaka serhiy-storchaka commented Nov 6, 2018

@serhiy-storchaka
Copy link
Member Author

If there are no objections I am going to merge this PR in few days.

Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I just have a very minor suggestion.

@@ -1,13 +1,6 @@
#! /usr/bin/env python3

"""Non-terminal symbols of Python grammar (from "graminit.h")."""

# This file is automatically generated; please don't muck it up!
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe document which tool generates it.

@serhiy-storchaka serhiy-storchaka merged commit 8ac6581 into python:master Dec 22, 2018
@serhiy-storchaka serhiy-storchaka deleted the regen-token2 branch December 22, 2018 09:18
gvanrossum added a commit to gvanrossum/cpython that referenced this pull request Jan 25, 2019
Grammar changes merged:
- PEP 572 (assignment expessions)
- pythonGH-10370 (slightly more lenient r.h.s. for annotated assignments)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type-feature A feature request or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants