-
-
Notifications
You must be signed in to change notification settings - Fork 30.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-110893: Improve docs for __future__
module
#112348
Conversation
__future__
module
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the PR and for contributing to CPython!
However, I think this still isn't clear enough about the ways in which __future__
is special, and the ways in which it is normal. I think this also regresses clarity in a few ways, e.g. talking about OptionalRelease
and MandatoryRelease
before these terms are defined, losing the fact that MandatoryRelease
is only a prediction and not a guarantee, etc. I merged https://github.com/python/cpython/pull/114642/files which attempts to address the first point here.
Deleting initial spaces was a mistake. PEP 8 comments are sentences.
A separate PR has made an alternate replacement of the initial 3 bullet points. Both replacements need to be read and merged into one expanded replacement. |
Could someone solve the merge conflicts? |
@JelleZijlstra Could you fix the merge conflicts between your PR and the first 3 paragraphs of this PR? I don't care or have any opinion how. If you think your version completely supercedes what it conflicts with, and no merging is needed, it would be trivial. |
I fixed the merge conflict between @hauntsaninja's PR that I merged some time ago and this one. I picked the text that we already have for the introductory paragraphs. The remaining changes in this PR don't solve any real problem as far as I can see, and I generally prefer the current wording over the changes in this PR. So I suggest closing this PR. With the merge resolution I pushed, this PR no longer removes the bullet points at the top of the |
I agree with Jelle! |
Related Issue
#110893 Improvements in the documentation future module
Changed file:
Doc/library/future.rst
📚 Documentation preview 📚: https://cpython-previews--112348.org.readthedocs.build/en/112348/library/__future__.html