Erase some unnecessary quotes on data model doc #113521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bedevere-app
bot
added
docs
The check about the f argument type was removed in this commit: python@2c94aa5 Thanks for Pedro Arthur Duarte (pedroarthur.jedi at gmail.com) by the help with this bug.
adorilson
force-pushed
the
improve_datamodel_doc
branch
from
f0029aa
to
cbcb98d
Compare
terryjreedy
reviewed
Feb 25, 2024
| @@ -266,4 +266,3 @@ Examples:: | |||
|
|
|||
| `NumPy <https://numpy.org/>`_ | |||
| The NumPy package defines another array type. | |||
|
|
|||
There was a problem hiding this comment.
Removing the extra newline is correct, but extraneous to the issue. I am leaving it, but normally better not to toss such things in.
terryjreedy
reviewed
Feb 25, 2024
| @@ -34,7 +34,7 @@ represented by objects.) | |||
|
|
|||
| Every object has an identity, a type and a value. An object's *identity* never | |||
| changes once it has been created; you may think of it as the object's address in | |||
| memory. The ':keyword:`is`' operator compares the identity of two objects; the | |||
| memory. The :keyword:`is` operator compares the identity of two objects; the | |||
There was a problem hiding this comment.
I suspect the quotes predate the :keyword: role tag.
terryjreedy
added
needs backport to 3.11
|
Thanks @adorilson for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Feb 25, 2024
Thanks to Pedro Arthur Duarte (pedroarthur.jedi at gmail.com) for help with this bug. (cherry picked from commit f745586) Co-authored-by: Adorilson Bezerra <adorilson@gmail.com>
|
GH-115896 is a backport of this pull request to the 3.12 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Feb 25, 2024
Thanks to Pedro Arthur Duarte (pedroarthur.jedi at gmail.com) for help with this bug. (cherry picked from commit f745586) Co-authored-by: Adorilson Bezerra <adorilson@gmail.com>
|
GH-115897 is a backport of this pull request to the 3.11 branch. |
terryjreedy
pushed a commit
that referenced
this pull request
Feb 25, 2024
terryjreedy
pushed a commit
that referenced
this pull request
Feb 25, 2024
woodruffw
pushed a commit
to woodruffw-forks/cpython
that referenced
this pull request
Mar 4, 2024
Thanks to Pedro Arthur Duarte (pedroarthur.jedi at gmail.com) for help with this bug.
diegorusso
pushed a commit
to diegorusso/cpython
that referenced
this pull request
Apr 17, 2024
Thanks to Pedro Arthur Duarte (pedroarthur.jedi at gmail.com) for help with this bug.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR before I start to work on #111746
📚 Documentation preview 📚: https://cpython-previews--113521.org.readthedocs.build/