gh-113102: Fix typo in INSTRUMENTED_RESUME #114349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
#113102 seems to be the issue for this. |
gvanrossum
changed the title
Oh, I did not know about that issue. This PR at least makes the code correct in case we decide that PY_RESUME is allowed to jump. If we decide it isn't, the code should be changed differently. Up to @markshannon I think. |
|
Thanks for fixing this. Whatever we decide about #113102, this is the correct thing to do in the interim. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was noted by @neonene in #111485 (comment). @markshannon replied positively (?) but nobody followed up. @markshannon do you still agree with @neonene's analysis that this was a typo?
PY_RESUMEevents? #113102