Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ftplib docs: timeout doesn't have to be a whole number #115443

Merged
merged 1 commit into from
Feb 14, 2024
Merged

ftplib docs: timeout doesn't have to be a whole number #115443

merged 1 commit into from
Feb 14, 2024

Conversation

AlexWaygood
Copy link
Member

@AlexWaygood AlexWaygood commented Feb 14, 2024 •
edited
Loading

See conversation in #114359 (comment)

📚 Documentation preview 📚: https://cpython-previews--115443.org.readthedocs.build/

@bedevere-app bedevere-app bot added awaiting core review docs Documentation in the Doc dir labels Feb 14, 2024
erlend-aasland
erlend-aasland approved these changes Feb 14, 2024
View reviewed changes
Copy link
Contributor

@erlend-aasland erlend-aasland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@AlexWaygood AlexWaygood merged commit 3fd2ad8 into python:main Feb 14, 2024
32 checks passed
@AlexWaygood AlexWaygood deleted the ftplib-floats branch February 14, 2024 10:41
@miss-islington-app
Copy link

Thanks @AlexWaygood for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 14, 2024
@AlexWaygood @miss-islington
ftplib docs: timeout doesn't have to be a whole number (pythonGH-11…
6efcaf1 
…5443)

(cherry picked from commit 3fd2ad8)

Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
@bedevere-app
Copy link

bedevere-app bot commented Feb 14, 2024

GH-115445 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 bug and security fixes label Feb 14, 2024
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 14, 2024
@AlexWaygood @miss-islington
ftplib docs: timeout doesn't have to be a whole number (pythonGH-11…
d6c80d7 
…5443)

(cherry picked from commit 3fd2ad8)

Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
@bedevere-app
Copy link

bedevere-app bot commented Feb 14, 2024

GH-115446 is a backport of this pull request to the 3.11 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.11 only security fixes label Feb 14, 2024
AlexWaygood added a commit that referenced this pull request Feb 14, 2024
@miss-islington @AlexWaygood
[3.12] ftplib docs: timeout doesn't have to be a whole number (GH-1…
644aeb5 
…15443) (#115445)

ftplib docs: `timeout` doesn't have to be a whole number (GH-115443)
(cherry picked from commit 3fd2ad8)

Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
AlexWaygood added a commit that referenced this pull request Feb 14, 2024
@miss-islington @AlexWaygood
[3.11] ftplib docs: timeout doesn't have to be a whole number (GH-1…
c274fe7 
…15443) (#115446)

ftplib docs: `timeout` doesn't have to be a whole number (GH-115443)
(cherry picked from commit 3fd2ad8)

Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
fsc-eriker pushed a commit to fsc-eriker/cpython that referenced this pull request Feb 14, 2024
@AlexWaygood @fsc-eriker
ftplib docs: timeout doesn't have to be a whole number (python#115443)
e8608ea
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erlend-aasland erlend-aasland erlend-aasland approved these changes

Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip issue skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@AlexWaygood @erlend-aasland