bpo-36878: Allow extra text after # type: ignore comments
#13238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the parser, when using the type_comments=True option, recognize a TYPE_IGNORE as anything containing `# type: ignore` followed by a non-alphanumeric character. This is to allow ignores such as `# type: ignore[E1000]`.
|
|
ilevkivskyi
approved these changes
May 11, 2019
|
|
||
| def baz(): | ||
| pass # type: ignore[excuse] | ||
| x = 1 # type: ignore whatever |
There was a problem hiding this comment.
Not that this is super-important, but I would add two other typical scenarios:
# type: ignore=excuse <- Pylint style
# type: ignore [excuse] <- just in case
|
It occurs to me there is one awkward thing about how the current isalnum check operates, which is that things like |
|
@msullivan Well, at least |
|
@gvanrossum If you don't have any other suggestion, I am going to merge this soon. |
ilevkivskyi
pushed a commit
that referenced
this pull request
May 22, 2019
) GH-13238 made extra text after a # type: ignore accepted by the parser. This finishes the job and actually plumbs the extra text through the parser and makes it available in the AST.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the parser, when using the type_comments=True option, recognize
a TYPE_IGNORE as anything containing
# type: ignorefollowed bya non-alphanumeric character. This is to allow ignores such as
# type: ignore[E1000].This doesn't provide the text in the syntax tree yet, which might be worth also doing.
But this is a sufficient start, since tools can pull it out themselves based on line numbers.
This may also want a PEP 484 update, but I think that might want to wait on some consensus/discussion about specific details.
https://bugs.python.org/issue36878