Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-21120: Exclude Python-ast.h, ast.h and asdl.h from the limited API #14634

Merged
merged 1 commit into from
Sep 12, 2019
Merged

bpo-21120: Exclude Python-ast.h, ast.h and asdl.h from the limited API #14634

merged 1 commit into from
Sep 12, 2019

Conversation

ZackerySpytz
Copy link
Contributor

@ZackerySpytz ZackerySpytz commented Jul 7, 2019 •
edited by bedevere-bot
Loading

The PyArena type is not part of the limited API, so these headers
shouldn't be part of it either.

https://bugs.python.org/issue21120

@ZackerySpytz
bpo-21120: Exclude Python-ast.h, ast.h and asdl.h from the limited API
87c04a7 
The PyArena type is not part of the limited API, so these headers
shouldn't be part of it either.
jdemeyer
jdemeyer approved these changes Jul 7, 2019
View reviewed changes
Copy link
Contributor

@jdemeyer jdemeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really just documenting what's already the case (this functionality is already not part of the limited API by PEP 384), so looks good to me.

@brettcannon brettcannon added the type-bug An unexpected behavior, bug, or error label Jul 11, 2019
@markshannon markshannon merged commit 421a72a into python:master Sep 12, 2019
@bedevere-bot
Copy link

@markshannon: Please replace # with GH- in the commit message next time. Thanks!

DinoV pushed a commit to DinoV/cpython that referenced this pull request Sep 12, 2019
@ZackerySpytz @DinoV
bpo-21120: Exclude Python-ast.h, ast.h and asdl.h from the limited API (
8bac4cf 
python#14634)

The PyArena type is not part of the limited API, so these headers
shouldn't be part of it either.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdemeyer jdemeyer jdemeyer approved these changes

Assignees
No one assigned
Labels
type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ZackerySpytz @bedevere-bot @jdemeyer @brettcannon @markshannon @the-knights-who-say-ni