Indent code inside if block #15284
Merged
Indent code inside if block #15284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Without indendation, seems like strcpy line is parallel to `if` condition * Improves readability
benjaminp
added
skip issue
skip news
needs backport to 3.7
needs backport to 3.8
|
Thanks @hansrajdas for the PR, and @benjaminp for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Aug 15, 2019
Without indendation, seems like strcpy line is parallel to `if` condition. (cherry picked from commit 69f37bc) Co-authored-by: Hansraj Das <raj.das.136@gmail.com>
|
GH-15306 is a backport of this pull request to the 3.8 branch. |
bedevere-bot
removed
needs backport to 3.8
|
GH-15307 is a backport of this pull request to the 3.7 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Aug 15, 2019
Without indendation, seems like strcpy line is parallel to `if` condition. (cherry picked from commit 69f37bc) Co-authored-by: Hansraj Das <raj.das.136@gmail.com>
miss-islington
added a commit
that referenced
this pull request
Aug 15, 2019
Without indendation, seems like strcpy line is parallel to `if` condition. (cherry picked from commit 69f37bc) Co-authored-by: Hansraj Das <raj.das.136@gmail.com>
miss-islington
added a commit
that referenced
this pull request
Aug 15, 2019
Without indendation, seems like strcpy line is parallel to `if` condition. (cherry picked from commit 69f37bc) Co-authored-by: Hansraj Das <raj.das.136@gmail.com>
lisroach
pushed a commit
to lisroach/cpython
that referenced
this pull request
Sep 10, 2019
Without indendation, seems like strcpy line is parallel to `if` condition.
DinoV
pushed a commit
to DinoV/cpython
that referenced
this pull request
Jan 14, 2020
Without indendation, seems like strcpy line is parallel to `if` condition.
websurfer5
pushed a commit
to websurfer5/cpython
that referenced
this pull request
Jul 20, 2020
Without indendation, seems like strcpy line is parallel to `if` condition.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ifcondition