-
-
Notifications
You must be signed in to change notification settings - Fork 30.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed typos in the documentation #15416
Conversation
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA). Our records indicate we have not received your CLA. For legal reasons we need you to sign this before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. If you have recently signed the CLA, please wait at least one business day You can check yourself to see if the CLA has been received. Thanks again for your contribution, we look forward to reviewing it! |
Thanks for the PR @shashi278! For me to merge this you need to fix the CLA. Check the instructions in Bedervere's comment :) |
Thanks, @pablogsal ! I signed the CLA as instructed. :) |
Don't worry about the Azure failure, is unrelated |
@shashi278 We need to wait until the CLA signed is registered |
Co-Authored-By: Antoine <43954001+awecx@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thanks
Thanks! Are we waiting for more reviews? |
Yeah, now a core developer will need to review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks @shashi278 for the PR! :)
Hummmm, there are some CI failures because some unrelated stuff. I will close and reopen the PR to retrigger the CI. |
Congrats @shashi278 for your first commit into CPython! 🎉 |
Yay! I'm a contributor now. |
Co-Authored-By: Antoine <43954001+awecx@users.noreply.github.com>
Co-Authored-By: Antoine <43954001+awecx@users.noreply.github.com>
Co-Authored-By: Antoine <43954001+awecx@users.noreply.github.com>
No description provided.