Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed typos in the documentation #15416

Merged
merged 2 commits into from
Aug 24, 2019
Merged

Fixed typos in the documentation #15416

merged 2 commits into from
Aug 24, 2019

Conversation

shashi278
Copy link
Contributor

No description provided.

@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Our records indicate we have not received your CLA. For legal reasons we need you to sign this before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

If you have recently signed the CLA, please wait at least one business day
before our records are updated.

You can check yourself to see if the CLA has been received.

Thanks again for your contribution, we look forward to reviewing it!

@pablogsal
Copy link
Member

Thanks for the PR @shashi278!

For me to merge this you need to fix the CLA. Check the instructions in Bedervere's comment :)

@pablogsal pablogsal self-assigned this Aug 23, 2019
@shashi278
Copy link
Contributor Author

Thanks, @pablogsal ! I signed the CLA as instructed. :)

@pablogsal
Copy link
Member

Don't worry about the Azure failure, is unrelated

@pablogsal
Copy link
Member

@shashi278 We need to wait until the CLA signed is registered

Parser/pgen/pgen.py Outdated Show resolved Hide resolved
Co-Authored-By: Antoine <43954001+awecx@users.noreply.github.com>
Copy link
Contributor

@epicfaace epicfaace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks

@shashi278
Copy link
Contributor Author

Thanks! Are we waiting for more reviews?

@epicfaace
Copy link
Contributor

Yeah, now a core developer will need to review.

Copy link
Member

@pablogsal pablogsal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @shashi278 for the PR! :)

@pablogsal
Copy link
Member

Hummmm, there are some CI failures because some unrelated stuff. I will close and reopen the PR to retrigger the CI.

@pablogsal pablogsal closed this Aug 24, 2019
@pablogsal pablogsal reopened this Aug 24, 2019
@pablogsal pablogsal merged commit 43710b6 into python:master Aug 24, 2019
@pablogsal
Copy link
Member

Congrats @shashi278 for your first commit into CPython! 🎉

@shashi278
Copy link
Contributor Author

Yay! I'm a contributor now.
Thanks to @pablogsal and others for suggestions, support, and encouragement.

lisroach pushed a commit to lisroach/cpython that referenced this pull request Sep 10, 2019
Co-Authored-By: Antoine <43954001+awecx@users.noreply.github.com>
DinoV pushed a commit to DinoV/cpython that referenced this pull request Jan 14, 2020
Co-Authored-By: Antoine <43954001+awecx@users.noreply.github.com>
websurfer5 pushed a commit to websurfer5/cpython that referenced this pull request Jul 20, 2020
Co-Authored-By: Antoine <43954001+awecx@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants