bpo-37589: Add a few missing dependencies on .h files in the Makefile. #15757
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dependencies prevented incremental builds from working when you touched any of these files.
Yhg1s
added
skip news
needs backport to 3.7
needs backport to 3.8
gpshead
approved these changes
Sep 9, 2019
|
Thanks @Yhg1s for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Sep 9, 2019
pythonGH-15757) The missing dependencies prevented incremental builds from working when you touched any of these files. Based on pythonGH-14758 by @vemakereporter. (cherry picked from commit b4612f5) Co-authored-by: T. Wouters <thomas@python.org>
|
GH-15767 is a backport of this pull request to the 3.8 branch. |
|
Sorry, @Yhg1s, I could not cleanly backport this to |
Yhg1s
added a commit
to Yhg1s/cpython
that referenced
this pull request
Sep 9, 2019
…kefile. (pythonGH-15757) The missing dependencies prevented incremental builds from working when you touched any of these files. Based on pythonGH-14758 by @vemakereporter.. (cherry picked from commit b4612f5) Co-authored-by: T. Wouters <thomas@python.org>
|
GH-15769 is a backport of this pull request to the 3.7 branch. |
miss-islington
added a commit
that referenced
this pull request
Sep 9, 2019
GH-15757) The missing dependencies prevented incremental builds from working when you touched any of these files. Based on GH-14758 by @vemakereporter. (cherry picked from commit b4612f5) Co-authored-by: T. Wouters <thomas@python.org>
miss-islington
pushed a commit
that referenced
this pull request
Sep 9, 2019
…kefile. (GH-15757) (GH-15769) The missing dependencies prevented incremental builds from working when you touched any of these files. Based on GH-14758 by @vemakereporter.. (cherry picked from commit b4612f5) https://bugs.python.org/issue37589 Automerge-Triggered-By: @gpshead
DinoV
pushed a commit
to DinoV/cpython
that referenced
this pull request
Jan 14, 2020
pythonGH-15757) The missing dependencies prevented incremental builds from working when you touched any of these files. Based on pythonGH-14758 by @vemakereporter.
websurfer5
pushed a commit
to websurfer5/cpython
that referenced
this pull request
Jul 20, 2020
pythonGH-15757) The missing dependencies prevented incremental builds from working when you touched any of these files. Based on pythonGH-14758 by @vemakereporter.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a few missing dependencies on .h files in the Makefile. The missing dependencies prevented incremental builds from working when you touched any of these files. Based on GH-14758 by @vemakereporter.
https://bugs.python.org/issue37589