bpo-38140: Make dict and weakref offsets opaque for C heap types #16076
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes
tp_dictoffset
andtp_weaklistoffset
completely opaque for C heap allocated types created through PyType_FromSpec.The type system already provides a way to pass in readonly primitive types. This uses that mechanism to pass in the offset values through the two keywords:
__dictoffset__
and__weaklistoffset__
. This then extends the type system to sniff for these values to set the offsets into the type.To provide uniformity, the passed in member types are required to have a
T_PYSSIZET
as well as beingREADONLY
https://bugs.python.org/issue38140