-
-
Notifications
You must be signed in to change notification settings - Fork 30.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Doc: remove duplicate word in controlflow tutorial #16163
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi! Thanks for improving the documentation!
In this commit you rewrapped a lot of paragraphs without changing them, which is bad for the log readability. (It mess with git blame, it's hard to review as it's long to find the actual modification, ...).
Can you please rollback those changes and do a minimal commit with just the removal of the duplicate word? I bet the paragraph containing the removed word don't needs rewrapping neither after the removal.
You can simply add a new commit to your branch and push it, as anyway both commits will be squashed while being merged: you don't have to force push, just add a new commit.
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
As you did it in two separate commit (good) you can simply run |
I have made the requested changes; please review again But, I made a revert wrong. Then I reverted the revert. :/ If you prefer, I can redo the PR from scratch. My bad. |
Thanks for making the requested changes! @JulienPalard: please review the changes made to this pull request. |
Thanks @adorilson for the PR, and @JulienPalard for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8. |
Sorry @adorilson and @JulienPalard, I had trouble checking out the |
@adorilson thanks! The series of revert if not a problem as we squash before merging, see: b7af4e7 it's clean. |
Thanks @adorilson for the PR, and @JulienPalard for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8. |
GH-16177 is a backport of this pull request to the 3.8 branch. |
(cherry picked from commit b7af4e7) Co-authored-by: Adorilson Bezerra <adorilson@gmail.com>
Just remove duplicate word in sentence: