-
-
Notifications
You must be signed in to change notification settings - Fork 30.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bpo-26329: update os.path.normpath documentation #20138
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this contribution @furkanonder . Please add Jack McCracken as co-author since he originally authored this patch.
I will ping @serhiy-storchaka for a second eye.
Finally, I made a different change in PR than Jack McCracken's patch. Do I still have to add he as a co-author? I think it is not necessary. |
The thing is you should still credit him because you still build on his PR. |
I added Jack McCracken as Co-author. |
I have made the requested changes; please review again. |
Thanks for making the requested changes! : please review the changes made to this pull request. |
Let us give @serhiy-storchaka some time to comment before merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We may need to backport to 3.9 and 3.10, but I will leave the backport PRs up for sometime before merge.
Thanks for the contribution @furkanonder and for the approval @ronaldoussoren. |
Thanks @furkanonder for the PR, and @nanjekyejoannah for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.9. |
GH-27094 is a backport of this pull request to the 3.10 branch. |
* bpo-26329: update os.path.normpath documentation * Update os.path.rst * Update posixpath.py * update Pathname Resolution note (cherry picked from commit 66c5853) Co-authored-by: Furkan Onder <furkanonder@protonmail.com>
* bpo-26329: update os.path.normpath documentation * Update os.path.rst * Update posixpath.py * update Pathname Resolution note (cherry picked from commit 66c5853) Co-authored-by: Furkan Onder <furkanonder@protonmail.com>
|
https://bugs.python.org/issue26329
Co-author by Jack McCracken.