Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-26329: update os.path.normpath documentation #20138

Merged
merged 4 commits into from
Jul 12, 2021
Merged

bpo-26329: update os.path.normpath documentation #20138

merged 4 commits into from
Jul 12, 2021

Conversation

furkanonder
Copy link
Contributor

@furkanonder furkanonder commented May 16, 2020

https://bugs.python.org/issue26329

Co-author by Jack McCracken.

@furkanonder
Copy link
Contributor Author

@nanjekyejoannah

Copy link
Contributor

@nanjekyejoannah nanjekyejoannah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this contribution @furkanonder . Please add Jack McCracken as co-author since he originally authored this patch.

I will ping @serhiy-storchaka for a second eye.

@furkanonder
Copy link
Contributor Author

Thanks for this contribution @furkanonder . Please add Jack McCracken as co-author since he originally authored this patch.

I will ping @serhiy-storchaka for a second eye.

Finally, I made a different change in PR than Jack McCracken's patch. Do I still have to add he as a co-author? I think it is not necessary.

@nanjekyejoannah
Copy link
Contributor

Thanks for this contribution @furkanonder . Please add Jack McCracken as co-author since he originally authored this patch.
I will ping @serhiy-storchaka for a second eye.

Finally, I made a different change in PR than Jack McCracken's patch. Do I still have to add he as a co-author? I think it is not necessary.

The thing is you should still credit him because you still build on his PR.
I can still see parts of his work that are still unchanged in your PR, a quick glance on the note shows some of his changes there too. You have indeed improved the original patch but I think you are still building on his work. It's just a credit to to appreciate.

@furkanonder
Copy link
Contributor Author

Thanks for this contribution @furkanonder . Please add Jack McCracken as co-author since he originally authored this patch.
I will ping @serhiy-storchaka for a second eye.

Finally, I made a different change in PR than Jack McCracken's patch. Do I still have to add he as a co-author? I think it is not necessary.

The thing is you should still credit him because you still build on his PR.
I can still see parts of his work that are still unchanged in your PR, a quick glance on the note shows some of his changes there too. You have indeed improved the original patch but I think you are still building on his work. It's just a credit to to appreciate.

I added Jack McCracken as Co-author.

@furkanonder
Copy link
Contributor Author

I have made the requested changes; please review again.

@bedevere-bot
Copy link

Thanks for making the requested changes!

: please review the changes made to this pull request.

@nanjekyejoannah
Copy link
Contributor

Let us give @serhiy-storchaka some time to comment before merge.

Copy link
Contributor

@ronaldoussoren ronaldoussoren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@nanjekyejoannah nanjekyejoannah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We may need to backport to 3.9 and 3.10, but I will leave the backport PRs up for sometime before merge.

@nanjekyejoannah nanjekyejoannah added needs backport to 3.9 only security fixes needs backport to 3.10 only security fixes labels Jul 12, 2021
@nanjekyejoannah
Copy link
Contributor

Thanks for the contribution @furkanonder and for the approval @ronaldoussoren.

@nanjekyejoannah nanjekyejoannah merged commit 66c5853 into python:main Jul 12, 2021
@miss-islington
Copy link
Contributor

Thanks @furkanonder for the PR, and @nanjekyejoannah for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.9.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-27094 is a backport of this pull request to the 3.10 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 12, 2021
* bpo-26329: update os.path.normpath documentation

* Update os.path.rst

* Update posixpath.py

* update Pathname Resolution note
(cherry picked from commit 66c5853)

Co-authored-by: Furkan Onder <furkanonder@protonmail.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 12, 2021
* bpo-26329: update os.path.normpath documentation

* Update os.path.rst

* Update posixpath.py

* update Pathname Resolution note
(cherry picked from commit 66c5853)

Co-authored-by: Furkan Onder <furkanonder@protonmail.com>
ambv pushed a commit that referenced this pull request Jul 12, 2021
(cherry picked from commit 66c5853)

Co-authored-by: Furkan Onder <furkanonder@protonmail.com>
ambv pushed a commit that referenced this pull request Jul 12, 2021
(cherry picked from commit 66c5853)

Co-authored-by: Furkan Onder <furkanonder@protonmail.com>
@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot s390x RHEL8 3.10 has failed when building commit 443db64.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/700/builds/184) and take a look at the build logs.
  4. Check if the failure is related to this commit (443db64) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/700/builds/184

Summary of the results of the build (if available):

== Tests result: ENV CHANGED ==

412 tests OK.

10 slowest tests:

  • test_concurrent_futures: 3 min 15 sec
  • test_gdb: 1 min 37 sec
  • test_multiprocessing_spawn: 1 min 36 sec
  • test_peg_generator: 1 min 28 sec
  • test_unparse: 1 min 22 sec
  • test_multiprocessing_forkserver: 1 min 13 sec
  • test_capi: 1 min 7 sec
  • test_tokenize: 1 min 3 sec
  • test_multiprocessing_fork: 58.5 sec
  • test_asyncio: 55.5 sec

1 test altered the execution environment:
test_asyncio

14 tests skipped:
test_devpoll test_ioctl test_kqueue test_msilib test_nis
test_ossaudiodev test_startfile test_tix test_tk test_ttk_guionly
test_winconsoleio test_winreg test_winsound test_zipfile64

Total duration: 6 min 10 sec

Click to see traceback logs
Traceback (most recent call last):
  File "/home/dje/cpython-buildarea/3.10.edelsohn-rhel8-z/build/Lib/asyncio/sslproto.py", line 321, in __del__
    self.close()
  File "/home/dje/cpython-buildarea/3.10.edelsohn-rhel8-z/build/Lib/asyncio/sslproto.py", line 316, in close
    self._ssl_protocol._start_shutdown()
  File "/home/dje/cpython-buildarea/3.10.edelsohn-rhel8-z/build/Lib/asyncio/sslproto.py", line 590, in _start_shutdown
    self._abort()
  File "/home/dje/cpython-buildarea/3.10.edelsohn-rhel8-z/build/Lib/asyncio/sslproto.py", line 731, in _abort
    self._transport.abort()
  File "/home/dje/cpython-buildarea/3.10.edelsohn-rhel8-z/build/Lib/asyncio/selector_events.py", line 680, in abort
    self._force_close(None)
  File "/home/dje/cpython-buildarea/3.10.edelsohn-rhel8-z/build/Lib/asyncio/selector_events.py", line 731, in _force_close
    self._loop.call_soon(self._call_connection_lost, exc)
  File "/home/dje/cpython-buildarea/3.10.edelsohn-rhel8-z/build/Lib/asyncio/base_events.py", line 745, in call_soon
    self._check_closed()
  File "/home/dje/cpython-buildarea/3.10.edelsohn-rhel8-z/build/Lib/asyncio/base_events.py", line 510, in _check_closed
    raise RuntimeError('Event loop is closed')
RuntimeError: Event loop is closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants