bpo-27268: Fix incorrect error message on float('') #2745
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhettinger
approved these changes
Sep 24, 2017
auvipy
approved these changes
Aug 25, 2018
|
@rhettinger, you approved this awhile ago. Were you waiting on anything in order to merge it? Thanks! |
|
@pslacerda, thanks for the pull request. Your change has now been merged. 🎉 🎉 |
|
Thank you @csabella, I just got something from the issue tracker and put here. Did you imagine someone (especially novices) really tricked seeing such weird error message? I'm glad it was merged! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue27268